Fix heap buffer overflow in H5VM_array_fill()#6513
Draft
jhendersonHDF wants to merge 1 commit into
Draft
Conversation
jhendersonHDF
added
the
Component - C Library
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
|
Fixes a heap buffer overflow that occurs due to a decoded fill value message's size not matching the size of the fill value's datatype. This results in a buffer being allocated with an incorrect size that is later overflowed when reading the fill value for chunks that haven't been allocated yet. Similar logic existed for decoding 'old' format fill value messages, but was not added for decoding 'new' format fill value messages
jhendersonHDF
force-pushed
the
H5VM_array_fill_overflow
branch
from
39e9f35 to
f6d805d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a heap buffer overflow that occurs due to a decoded fill value message's size not matching the size of the fill value's datatype. This results in a buffer being allocated with an incorrect size that is later overflowed when reading the fill value for chunks that haven't been allocated yet. Similar logic existed for decoding 'old' format fill value messages, but was not added for decoding 'new' format fill value messages.