fix: make review repairs converge - #242
Open
Arismemo wants to merge 13 commits into
Open
Conversation
Owner
|
Thank you for submitting the pull request. We will test it and evaluate the merge as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root causes
Storyboard review loop
The storyboard-table agent never read the current
storyboardTableduring repair runs. Every repair regenerated the whole table from script, assets, and plan data, so fixed items regressed while the independent reviewer found different issues each round. The reviewer also did not receive the prior report as a frozen acceptance checklist.Script adaptation review loop
One user confirmation could require changes to both
storySkeletonandadaptationStrategy, but the decision agent called only one executor and then claimed both workspaces were synchronized. The stale downstream strategy contradicted the updated skeleton. Generic per-stage instructions also allowed supervision to run after the first workspace, while the reviewer repeatedly reopened confirmed tradeoffs and applied long-form paid-series rules to a one-episode 30-second children's short.OpenAI-compatible video failures
The adapter discarded string-valued upstream errors, so actionable failures appeared only as HTTP 400. Live endpoint reproduction confirmed three independent constraints: reference-to-video duration is limited to 10 seconds, prompt length is limited to 4096 UTF-8 bytes, and content moderation failures return a structured
imagine:content-moderatedresponse.Verification
yarn test:script-agent-review— 6/6 passedyarn test:openai-image— 5/5 passedyarn test:openai-video— 7/7 passedyarn lintyarn buildgit diff --check1785157202433: story skeleton executor completed, adaptation strategy executor completed, then one final review ranA — 可直接使用and explicitly closed the confirmed shoe-lace tradeoff instead of reopening itffprobe(H.264, 848×480, non-zero duration)Target
develop