feat: improve Learning Console readability - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read-only review findings
The merged PR #41 baseline was functional and scientifically careful, but still read like a project report in several places. The opening did not explain why folk music was being used; the learner was asked to predict without a concrete instruction; the real-data journey began with
EXP-010A; hardware terminology arrived before its meaning; and Foundations exposed route/version metadata plus a duplicate title.Learner-facing blocks removed or rewritten
Guided experimentwith the prediction questionCan you spot the hidden split?.EXP-010Aopening and the duplicated feature-summary blocks.EXP-010DandEXP-011primary headings with plain-language replication headings; governed IDs remain as captions.Change classification
This is a copy-led readability change with small ordering/removal changes. It adds no navigation architecture, custom styling, registry, evidence layer or product feature.
The final amendment moves the choices table, input contract and five-step encoding process into a collapsed
How the four-bit model worksdisclosure after the replicated hardware evidence. It also renames README'sFour proof pointssection toWhat you can inspectand explains rho as agreement between rankings. No screenshot was added.Scientific components deliberately frozen
Validation
git diff --check: passed.Visual review
scrollWidth == clientWidth == 700);No IBM service was contacted, no credential was accessed, PR #23 was untouched, and the primary checkout's
.gitignoreand.claude/state was preserved.Review focus
Novice README and reproducibility amendment
Head commit:
e975c8a932bc9aaa7762b47c20c9103464ff5267Summary
First: what is the exact answer?in the real-data journey and presentsEXP-010A · compact real-data formulationas secondary provenance;software_provenance.pythonon non-mutating copies;OPENAI_API_KEYvariable name with a placeholder while retaining detection of key-like secret values;Exact amendment files
README.mdapps/learning_console/README.mdapps/learning_console/renderers/compact_experiment.pydocs/build-week/DEMO-SCRIPT.mddocs/build-week/JUDGING-GUIDE.mddocs/build-week/KNOWN-LIMITATIONS.mddocs/build-week/SUBMISSION-CHECKLIST.mdscripts/check_public_safety.pyscripts/verify_build_week_release.pytests/build_week/test_release_verification.pytests/learning/test_build_week_console.pytests/test_no_secrets.pyDiagnosis and fix
The old verifier compared the committed example and runtime-generated envelope directly, making the interpreter version itself a stale-export failure. The new helper deep-copies both payloads and removes only
software_provenance.pythonbefore comparison. Regression tests prove3.13.5versus3.12.13passes and a changed scientific result still fails. On locally available Python 3.11.9, two validation tolerances also changed near10^-15; the verifier correctly continued to fail rather than ignore those scientific fields.Validation
.[learning]install and credential-free Streamlit launch: HTTP 200;Python 3.12 was not installed on this machine, and the request to add a persistent interpreter was denied. The exact 3.12.13 version-only case is covered by regression; an independent clean 3.12 execution remains a review follow-up if required.
All registered evidence and scientific values remain unchanged. No IBM or OpenAI service was contacted, no credential was accessed, PR #23 was untouched, and PR #42 remains draft.