Skip to content

refactor(frontend): adopt ui primitives in transactions #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GusGaiotti merged 1 commit into from
Jul 9, 2026
Merged

refactor(frontend): adopt ui primitives in transactions #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions frontend/src/app/(app)/transactions/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { PageHeader } from "@/components/shared/PageHeader";
import { TransactionDrawer } from "@/components/transactions/TransactionDrawer";
import { TransactionFilters } from "@/components/transactions/TransactionFilters";
import { TransactionTable } from "@/components/transactions/TransactionTable";
import { Alert, Badge, Button } from "@/components/ui";
import { useCategories } from "@/hooks/useCategories";
import { useLedger } from "@/hooks/useLedger";
import {
Expand Down Expand Up @@ -145,24 +146,24 @@ export default function TransactionsPage() {
buttonClassName="w-full px-3 py-2 sm:min-w-[190px] sm:w-auto"
align="right"
/>
<button
className="focusable h-11 w-full rounded-xl bg-[var(--accent)] px-4 text-sm font-semibold text-white shadow-[0_8px_24px_rgba(79,124,255,0.35)] transition-colors duration-150 hover:bg-[var(--accent-hover)] sm:w-auto"
<Button
className="w-full sm:w-auto"
onClick={() => {
setEditingTransaction(null);
setErrorMessage(null);
setOpen(true);
}}
>
Nova transação
</button>
</Button>
</div>
}
/>

{errorMessage ? (
<div className="mb-4 rounded-xl border border-[color-mix(in_srgb,var(--expense)_32%,transparent)] bg-[color-mix(in_srgb,var(--expense)_10%,var(--panel-bg))] px-4 py-3 text-sm text-[color-mix(in_srgb,var(--expense)_82%,var(--text-primary))]">
<Alert tone="danger" className="mb-4">
{errorMessage}
</div>
</Alert>
) : null}

<div className="surface mb-4 grid gap-3 p-4 text-sm md:grid-cols-3">
Expand Down Expand Up @@ -191,13 +192,10 @@ export default function TransactionsPage() {
{Object.keys(totals.expenseByPerson).length ? (
<div className="mb-4 flex flex-wrap gap-2">
{Object.entries(totals.expenseByPerson).map(([name, total]) => (
<span
key={name}
className="rounded-full border border-[var(--border)] bg-[var(--bg-elevated)] px-3 py-1 text-xs text-[var(--text-secondary)]"
>
<Badge key={name} tone="neutral">
{name}:{" "}
<span className="font-mono text-[var(--expense)]">{formatCurrency(total)}</span>
</span>
<span className="ml-1 font-mono text-[var(--expense)]">{formatCurrency(total)}</span>
</Badge>
))}
</div>
) : null}
Expand Down Expand Up @@ -235,13 +233,15 @@ export default function TransactionsPage() {
/>

<div className="mt-4 flex items-center gap-2">
<button
<Button
variant="ghost"
size="sm"
className="border border-[var(--border)]"
disabled={!transactions.hasNextPage || transactions.isFetchingNextPage}
onClick={() => transactions.fetchNextPage()}
className="focusable rounded-xl border border-[var(--border)] px-3 py-2 text-sm text-[var(--text-secondary)] transition-all duration-150 hover:bg-[var(--bg-elevated)] disabled:cursor-not-allowed disabled:opacity-40"
>
{transactions.isFetchingNextPage ? "Carregando..." : "Carregar mais"}
</button>
</Button>
</div>

<TransactionDrawer
Expand Down
8 changes: 3 additions & 5 deletions frontend/src/components/transactions/TransactionDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import { useEffect, useId, useMemo, useRef, useState } from "react";
import { SelectMenu } from "@/components/shared/SelectMenu";
import { Button } from "@/components/ui";
import {
formatCurrency,
normalizeCurrencyInput,
Expand Down Expand Up @@ -90,7 +91,7 @@
}, [onClose]);

return (
<div

Check warning on line 94 in frontend/src/components/transactions/TransactionDrawer.tsx

View workflow job for this annotation

GitHub Actions / frontend 

Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element
className="fixed inset-0 z-50 flex items-center justify-center bg-black/55 p-4"
onMouseDown={(event) => {
if (event.target === event.currentTarget) {
Expand Down Expand Up @@ -186,12 +187,9 @@
/>
</label>
<div className="flex gap-2">
<button
disabled={isSubmitting || amountValue <= 0}
className="focusable h-11 flex-1 rounded-xl bg-[var(--accent)] px-4 font-semibold text-white shadow-[0_8px_24px_rgba(79,124,255,0.35)] transition-all duration-150 hover:bg-[var(--accent-hover)] disabled:cursor-not-allowed disabled:opacity-40"
>
<Button type="submit" className="flex-1" disabled={isSubmitting || amountValue <= 0}>
{isSubmitting ? "Salvando..." : isEditing ? "Salvar alterações" : "Salvar transação"}
</button>
</Button>
<button
type="button"
className="focusable h-11 rounded-xl border border-[color-mix(in_srgb,var(--expense)_30%,transparent)] bg-[color-mix(in_srgb,var(--expense)_10%,var(--panel-bg))] px-4 py-2 text-sm text-[color-mix(in_srgb,var(--expense)_84%,var(--text-primary))] transition-colors duration-150 hover:border-[color-mix(in_srgb,var(--expense)_42%,transparent)] hover:bg-[color-mix(in_srgb,var(--expense)_14%,var(--panel-bg))]"
Expand Down
Loading