Repository navigation
fix(ui-native): show Dialog and Drawer contents to VoiceOver (GRYT-2000) - #317
Merged
Merged
Conversation
A Pressable is accessible by default, which hides everything inside it. The backdrops wrap the panels, so the Drawer read as nothing and a Dialog as one long element with no buttons in it. Taps still close them, and the escape gesture now does too, because the backdrop is no longer focusable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the phone, the server drawer showed nothing in the accessibility tree and the welcome dialog was one long element with no buttons in it. A
Pressableisaccessibleby default, and that hides everything inside it. The backdrops wrap the panels.The backdrops, and the Drawer's panel, are now
accessible={false}. With the backdrop no longer focusable, VoiceOver needs another way out, soonAccessibilityEscapecloses both when they're dismissible.Tested by overlaying this build on the phone app, with the Maestro flows from Gryt-chat/mobile#482: buttons found by name in both, and tapping outside still closes the drawer.
Look at: I checked the accessibility tree through Maestro, not VoiceOver itself, which needs a real iPhone. The escape gesture isn't tested.
Sheetdoesn't wrap its panel in aPressable, so I left it alone.🤖 Generated with Claude Code