Repository navigation
Thread replies wake the people in the thread (GRYT-2008) - #360
Merged
Merged
Conversation
A reply in a thread pushed to nobody unless it mentioned them, so somebody who asked for help only heard back if the answer @mentioned them. Now everyone who wrote in the thread, the root's author included, gets the same "message" push as a channel set to All messages. That excludes the sender, anyone who blocked them and anyone who can no longer read the channel. Nobody else on the server is told, so a support thread doesn't ping everybody. It goes after the mention push, so a mention in a thread still reads as one notification inside the conversation's quiet window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review-required: adds
listThreadParticipantsinsrc/db/sqlite/threads.ts.A reply in a thread pushed to nobody unless it @mentioned them. Someone who asked for help in a thread only heard back if the answer mentioned them.
Now everyone who wrote in the thread, the root's author included, gets a
messagepush for a reply. Nobody else is told, so starting a support thread doesn't ping the server. It skips the sender, anyone who blocked them, and anyone who can no longer read the channel. Channel mutes and the 15-second quiet window apply as for any push.Look at
Tested: two end-to-end cases in
pushAudience.test.tsagainst a stand-in relay: the thread's people are woken and a bystander isn't, and the replier isn't woken. The first one fails with the push removed.🤖 Generated with Claude Code