Repository navigation
Guess the SFU's metrics URL from SFU_WS_HOST (GRYT-2005) - #359
Merged
Merged
Conversation
Without SFU_METRICS_URL, server:diagnostics now reads port 9091 on the host SFU_WS_HOST names, which is where the SFU serves them by default. A normal compose setup (ws://sfu:9092) gets its SFU numbers with no config. Host-networked setups like dev.lan's still set the env var; a wrong guess finds no gryt_sfu_ lines and shows none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
SFU_METRICS_URLunset,server:diagnosticsnow readshttp://<SFU_WS_HOST's host>:9091/metrics. That's where the SFU serves its metrics by default, so a normal compose setup (ws://sfu:9092) gets the SFU numbers with no config.The env var still wins. Host-networked setups like beta and prod on prod-host set it, because their
SFU_WS_HOSTpoints at a published port, not at the container. A wrong guess finds nogryt_sfu_lines and shows none. It doesn't show anything wrong.Look at: the guess makes the server fetch port 9091 on whatever host
SFU_WS_HOSTnames, but only when an owner asks for diagnostics. That host comes from the operator's own config.🤖 Generated with Claude Code