Repository navigation
feat: send each friend's avatar in the friend list - #355
Merged
Merged
Conversation
The phone's friends tab spans every server and showed an owl for anyone it had no member list or DM for, while the DM showed their picture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GRYT-1998.
friend:listnow includesavatarFileIdfor each person. Friends and requests on the phone's Messages tab showed an owl for anyone on another server with no DM.This waits for you: it touches
src/db/sqlite/friends.ts, a review-required path.Look at: it adds
u.avatar_file_idto the three friend queries. Members can already see each other's avatars, so nothing new is exposed to them, but a request from someone now also carries that person's avatar. The field is only added, so older clients ignore it.Typecheck passes. There's no test for these queries and I didn't run it against a live server.
🤖 Generated with Claude Code