Repository navigation
Don't count "joined the server" lines as unread - #354
Merged
Merged
Conversation
Since unopened channels count from when you joined, your own join line showed as one unread message, and every later join added another. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server 1.12.2 counts unread in unopened channels from when you joined (#352). Your own join line lands just after that moment, so a new member sees a badge of 1 on a channel nobody has written in, and every later join adds one. That is live on stable. It also makes client e2e red on main: the badge changes the channel row's name, so
navigation.spec.ts:37cannot find it.Both queries now skip messages from the
systemsender.Look at: this is in
db/, so it needs your read. It also changes channels that already have a marker: a join line after your marker no longer counts. That is a behaviour change, and I think the right one.Tested: new cases in
readMarkers.test.ts, and the client e2e navigation test against a local image built from this branch.After merge this needs a server release for client CI to go green, since e2e runs against
server:latest.Seen here and not changed: in that test the join line landed in
bravo-notes, not General.getSystemChannelIdtakes the first text channel fromlistServerChannels.🤖 Generated with Claude Code