Skip to content

Allow 300 chat uploads a minute per person (GRYT-1965) #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sivert-io merged 2 commits into from
Oct 31, 2026
Merged

Allow 300 chat uploads a minute per person (GRYT-1965) #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0847b9
Allow 300 uploads a minute per person (GRYT-1965)
grytchat Oct 31, 2026
e43b0d3
Give chat uploads their own limit instead of raising the shared one
grytchat Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { startWorkerCapabilityPolling } from "./services/workerCapabilities";
import { join } from "path";
import { config } from "dotenv";
import { applyCors, isOriginAllowed, readAllowedOrigins } from "./config/cors";
import { RL_HTTP_API, RL_HTTP_EMOJI_WRITE, RL_HTTP_FILE, RL_HTTP_OUTBOUND, RL_HTTP_PUBLIC, RL_HTTP_UPLOAD, httpRateLimit } from "./middleware/rateLimitHttp";
import { RL_HTTP_API, RL_HTTP_CHAT_UPLOAD, RL_HTTP_EMOJI_WRITE, RL_HTTP_FILE, RL_HTTP_OUTBOUND, RL_HTTP_PUBLIC, RL_HTTP_UPLOAD, httpRateLimit } from "./middleware/rateLimitHttp";
config({ path: "config.env", override: false });
config({ override: false });
import { consola } from "consola";
Expand Down Expand Up @@ -342,7 +342,7 @@ app.use("/api/server", httpRateLimit("http:server", RL_HTTP_UPLOAD), serverRoute
app.use("/api/messages", httpRateLimit("http:api", RL_HTTP_API), messagesRouter);
// Reads and writes share a mount and need different budgets. Express runs every
// matching mount, so without the skip a read is charged to the write budget.
const limitUploadWrites = httpRateLimit("http:upload", RL_HTTP_UPLOAD);
const limitUploadWrites = httpRateLimit("http:upload", RL_HTTP_CHAT_UPLOAD);
app.use("/api/uploads/files", httpRateLimit("http:file", RL_HTTP_FILE));
app.use(
"/api/uploads",
Expand Down
3 changes: 3 additions & 0 deletions src/middleware/rateLimitHttp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ export const RL_HTTP_OUTBOUND: RateLimitRule = { limit: 20, windowMs: 60_000, ba
/** Writing bytes to disk, which costs storage rather than only time. */
export const RL_HTTP_UPLOAD: RateLimitRule = { limit: 30, windowMs: 60_000, banMs: 30_000 };

/** Chat files. A Discord import sends hundreds of them in one go, and each is capped by size. */
export const RL_HTTP_CHAT_UPLOAD: RateLimitRule = { limit: 300, windowMs: 60_000, banMs: 30_000 };

/** An import is one gesture that becomes a request per emoji. No `banMs`: the
ban is what took the emoji list down with the writes. */
export const RL_HTTP_EMOJI_WRITE: RateLimitRule = { limit: 150, windowMs: 60_000 };
Expand Down
Loading