Repository navigation
Put the conversation and message in a push's sealed preview (GRYT-1976) - #351
Merged
Merged
Conversation
A push only carried a server tag and the sealed text, so tapping one could only open the server. The phone had nothing else to go on. The conversation id, the message id and a DM flag now go inside the seal, so the relay still can't read them. A thread reply and an MLS message send no message id, and the tap stops at the conversation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A push only carried a server tag and the sealed text, so a tap on the phone could only open the server. This adds the conversation id, the message id and a DM flag inside the seal. The relay still can't read them, and it needs no change.
Older phones ignore the new fields. The phone half, Gryt-chat/mobile#462, reads them, and without this PR it stops at the server as it does today. Either can land first.
Look at: the message id is left out for a thread reply, because that message isn't in the channel's list, and for MLS, where the server has no id to send. Those taps stop at the conversation.
Tested with
pushPreview.test.tsandpushAudience.test.ts. The simulator run is written up in the phone PR. No real push went through Apple or the relay.GRYT-1976
🤖 Generated with Claude Code