Repository navigation
fix: thread:history carries answer_message_id too - #349
Merged
Merged
Conversation
#348 added the answer to every summary built by toThreadSummary, but thread:fetch builds its thread object by hand, so opening a solved topic didn't show which reply answered it. Found checking the phone against it. Part of GRYT-1963. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #348. Part of GRYT-1963.
src/socketonly, but the same feature as #348, so it's yours to merge.#348 put
answer_message_idon every summary built bytoThreadSummary.thread:fetchbuilds itsthreadobject by hand instead, so it was missing there. Opening a solved topic on the phone showed "Solved" but not which reply answered it. I found it checking the phone in the simulator against a local server.One line in
thread:history, plus a check inthreadStatus.test.tsthatthread:fetchreturns the answer after it's set.🤖 Generated with Claude Code