Repository navigation
ci: count SQL -- comments in the two-line comment check (GRYT-1960) - #347
Merged
Merged
Conversation
Comments inside SQL template strings were invisible to the check, so a 12-line schema comment in server#346 passed it. The 15 existing runs in connection.ts are capped in SQL_DEBT, to be trimmed in GRYT-1960. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-comment-length.mtsread//,/* */and#, but not--inside the SQL template strings. So the 12-line schema comment in #346 passed the check. That one is trimmed in #346 now.--(or just--) counts as a comment line. A bare--is free, the same way a bare//is.src/db/sqlite/connection.tsare allowed through bySQL_DEBT, capped at 15. A new long one in that file pushes the count to 16 and fails. GRYT-1960 trims them and lowers the cap.I checked it both ways: it passes on main, and fails with 16 when #346's old comment is put back.
Only the script changes, so
src/dbisn't touched here.🤖 Generated with Claude Code