Repository navigation
A voice client can announce several shared windows (GRYT-1905) - #343
Merged
Merged
Conversation
voice:screen:state may carry shares: [{videoStreamId, audioStreamId}], checked and capped at 8.
Clients get screenShares; the old single fields keep the first window for older apps.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every member already sees the single share's stream ids; this is the same thing per window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third piece of sharing several windows at once (GRYT-1905), after Gryt-chat/sfu#67 and Gryt-chat/voice#134.
voice:screen:statemay carryshares: [{ videoStreamId, audioStreamId }].screenSharesFromreads it and keeps at most 8 entries, matching the SFU's ceiling. It drops anything that isn't an object with a string video id of up to 128 characters. A payload withoutsharesgives the single pair older apps send, so nothing changes for them.screenSharesin both member-list builders inutils/clients.ts.screenShareVideoStreamIDandscreenShareAudioStreamIDkeep the first window, so an app that knows one share still shows one.screenSharestoo: leaving, moving, kicking, a replaced socket, server restart cleanup.screenSharesis optional on the type, so the many test fixtures that build a client record don't change.Tests:
utils/screenShares.test.tscovers the legacy pair, several windows, malformed input and the ceiling. It passes alongside the permission-gate and client-record tests (164).screenSharesis added to the public field list inpublicClientList.test.ts, which pins what leaves the server. Every member already sees the single share's stream ids, and this is the same per window.Not in this PR: the client sending
sharesand drawing a tile per window.🤖 Generated with Claude Code