Skip to content

Only the phone that asked reacts to a no (GRYT-2023) #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grytchat merged 1 commit into from
Nov 3, 2026
Merged

Only the phone that asked reacts to a no (GRYT-2023) #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/mls/useServerMls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,16 @@ async function askOtherDevice(socket: Socket, host: string, dmScope: string, acc
const binding = await dmKeyBindingFor(dmScope);
const code = await handoverCode(dmScope, accountBinding, binding).catch(() => null);
socket.emit("dm:key:handover:ask", { binding, deviceName: Platform.OS === "ios" ? "iPhone" : "Android phone" });
socket.once("dm:key:handover:denied", () =>
// Every device on the account hears a no since GRYT-2023; only one naming this key is for us.
const denied = (no?: { binding?: string }) => {
if (no?.binding && no.binding !== binding) return;
socket.off("dm:key:handover:denied", denied);
Alert.alert("Your other device said no", "Nothing changed. If that was a mistake, approve this phone from another device.", [
{ text: "OK", style: "cancel" },
{ text: "Approve from another device", onPress: () => router.push("/link-from-device") },
]),
);
]);
};
socket.on("dm:key:handover:denied", denied);
Alert.alert(
"Approve on your other device",
`Your other device has a request from this phone. Open Gryt there and check it shows ${code ?? "the same code"}, then approve. ${host} then uses the same key as your other servers.`,
Expand Down
Loading