Repository navigation
Ban nested ternaries and non-null assertions in the client's lint (GRYT-1792) - #891
Merged
Merged
Conversation
…YT-1792) The rest of the rules the server, ui, core, voice and mobile now share: nested ternaries, non-null assertions, reassigned parameters, loose equality, else after return, let that could be const, and unmarked type-only imports. Existing debt is listed per rule in .eslintrc.cjs; no code file changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #890. One file,
.eslintrc.cjs, and no code changes.New errors:
no-nested-ternary,@typescript-eslint/no-non-null-assertion,no-param-reassign,eqeqeq(smart),no-else-return,prefer-const, andconsistent-type-imports(inline;typeof import()allowed). These match the server, ui, core, voice and mobile.Existing debt is listed per rule in
overrides:x!: 45elseafterreturn: 3yarn lintandcheck-comment-lengthpass.Vikunja: GRYT-1792
🤖 Generated with Claude Code