Repository navigation
Minimize to tray works without an account - #1180
Merged
Merged
Conversation
The close handler only hid the window to the tray when the renderer had said someone was signed in. With Local Identity nobody signs in, so "Minimize to tray on close" quit the app instead. The check is gone, and so is the signed-in flag and its IPC, which nothing else used. GRYT-2077 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From two bug reports, the latest on desktop 1.15.10 for Windows: with Local Identity, "Minimize to tray on close" quits the app instead of hiding it. The reporter found the cause and a workaround (
window.electronAPI.setSignedIn(true)in DevTools).The window's
closehandler only hid to the tray whenisUserSignedInwas true. That flag came from the renderer's account state, and with Local Identity nobody signs in, so it stayed false. The check dates from when the app asked people to pick an account or a guest identity before using it. That choice is gone.electron/main.ts: the close handler checks onlyisQuittingandcloseToTray.isUserSignedInand theset-signed-inIPC are removed.electron/preload.ts,src/lib/electron.ts:setSignedInis removed.useAccount.tsx: the effect that called it is removed.The behaviour change to look at: if someone has close-to-tray on, closing now always hides to the tray, signed in or not. The tray icon brings the window back.
GRYT-2077
🤖 Generated with Claude Code