Restore authored cheese wheel textures#211
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The 1.21 port replaced cheese-specific wheel models with shared grayscale models and runtime block tinting. This left the authored cheese textures unused and made ordinary wheels appear as flat solid colors.
Waxed models had two additional porting regressions: texture slot 1 referenced the waxed top instead of the waxed side, and the shared 1.21 geometry applied the side layer to dozens or hundreds of internal faces rather than the small set used in 1.20. This hid cheese interiors or repeated rind textures across individual voxel segments.
Result
Every cheese wheel once again uses its authored unaged, aged, unwaxed, or waxed textures. Waxed wheels retain their prescribed rind, and sliced wax-aged wheels expose the cheese interior without runtime tint multiplication. Curds and item rendering are outside this block-model restoration and remain unchanged.
Validation
./gradlew.bat compileJava -x createMinecraftArtifacts./gradlew.bat test --tests growthcraft.test.ContentBaselineTest -x createMinecraftArtifacts./gradlew.bat test -x createMinecraftArtifactsgit diff --checkCloses #210