Restore balanced Kumis fermentation#208
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Kumis remained disabled after its old invalid output ID was corrected during porting. The current Kumis fluid is registered under
growthcraft_milk, but the Fermentation Barrel's generic fluid interaction does not accept vanilla or Growthcraft milk buckets, leaving the restored recipe inaccessible through normal play.Kumis previously duplicated Pilsner Lager's Resistance II for three minutes despite skipping the lager's grain roasting and wort-brewing stages. Resistance I for five minutes gives the lower-effort drink a useful but distinct role.
Validation
./gradlew.bat test --tests growthcraft.test.RecipeResourceTest --tests growthcraft.test.RecipeRuntimeCatalogTest -x createMinecraftArtifacts./gradlew.bat compileJava -x createMinecraftArtifacts./gradlew.bat test -x createMinecraftArtifactsgit diff --checkCloses #195