Correct fermented drink colors#206
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrected drinks
Amber Ale, Amber Lager, Brown Ale, Copper Ale, Copper Lager, IPA Ale, Old Port Ale, Pale Lager, Purple Grape Wine, Red Grape Wine, White Grape Wine, Vienna Lager, Apple Cider, Honey Mead, Rice Wine, and Sake.
Root cause
Several recipe colors were copied from their input wort or must. The three grape wines, for example, all used the same brown value instead of their distinct result-fluid colors.
Validation
./gradlew.bat test --tests growthcraft.test.RecipeResourceTest --tests growthcraft.test.RecipeRuntimeCatalogTest -x createMinecraftArtifacts./gradlew.bat test -x createMinecraftArtifactsgit diff --checkCloses #197