Share heat-source detection across machines#204
Merged
Conversation
Alatyami
marked this pull request as ready for review
July 11, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HeatSourceUtilsgrowthcraft_cellar:heat_sourcesblock tag as the Cellar machinesRoot cause
Mixing Vat maintained a separate hard-coded heat check. It recognized several vanilla blocks but ignored datapack additions to the established heat-source tag and did not share the lava fallback used by the Cellar machines.
Validation
./gradlew.bat compileJava -x createMinecraftArtifacts./gradlew.bat test -x createMinecraftArtifactsgit diff --checkminecraft:diamond_blocktogrowthcraft_cellar:heat_sourcesthrough a temporary datapack and confirmed the machines detected it as expectedCloses #196