Skip to content

Share heat-source detection across machines#204

Merged
Alatyami merged 1 commit into
developmentfrom
bugfix/196-mixing-vat-heat-source-tag
Jul 11, 2026
Merged

Share heat-source detection across machines#204
Alatyami merged 1 commit into
developmentfrom
bugfix/196-mixing-vat-heat-source-tag

Conversation

@Alatyami

Copy link
Copy Markdown
Member

Summary

  • centralize heat-source classification in HeatSourceUtils
  • make Mixing Vat honor the same growthcraft_cellar:heat_sources block tag as the Cellar machines
  • reuse the helper from Brew Kettle, Roaster, and Culture Jar to remove duplicated classification logic
  • preserve each machine's existing search geometry: directly below for Vat/Kettle/Roaster and radius two for Culture Jar

Root cause

Mixing Vat maintained a separate hard-coded heat check. It recognized several vanilla blocks but ignored datapack additions to the established heat-source tag and did not share the lava fallback used by the Cellar machines.

Validation

  • ./gradlew.bat compileJava -x createMinecraftArtifacts
  • ./gradlew.bat test -x createMinecraftArtifacts
  • git diff --check
  • manually added minecraft:diamond_block to growthcraft_cellar:heat_sources through a temporary datapack and confirmed the machines detected it as expected

Closes #196

@Alatyami
Alatyami marked this pull request as ready for review July 11, 2026 20:16
@Alatyami
Alatyami merged commit 08a7fbc into development Jul 11, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the shared heat-source tag logic for the Mixing Vat

1 participant