Skip to content

Show fermented fluid names on filled drinks#203

Merged
Alatyami merged 1 commit into
developmentfrom
bugfix/200-fermented-fluid-names
Jul 11, 2026
Merged

Show fermented fluid names on filled drinks#203
Alatyami merged 1 commit into
developmentfrom
bugfix/200-fermented-fluid-names

Conversation

@Alatyami

Copy link
Copy Markdown
Member

Summary

  • name filled fermentation containers after the recipe's result fluid
  • preserve the configured bottle or pint-glass item
  • preserve potion effects, color, and other item components

Root cause

The recipe passed the fermented fluid name as an argument to the container item's translation component. Container keys such as Pint Glass (Lager) do not contain a substitution placeholder, so Minecraft ignored the fluid-name argument and displayed the generic container name.

Validation

  • ./gradlew.bat compileJava -x createMinecraftArtifacts
  • ./gradlew.bat test -x createMinecraftArtifacts
  • git diff --check
  • manually confirmed a filled lager pint glass displays the fermented fluid name while retaining its effects and container

Closes #200

@Alatyami Alatyami marked this pull request as ready for review July 11, 2026 20:00
@Alatyami Alatyami merged commit 036b5f3 into development Jul 11, 2026
2 of 3 checks passed
@Alatyami Alatyami deleted the bugfix/200-fermented-fluid-names branch July 11, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show fermented fluid names on filled bottles and pint glasses

1 participant