Repository navigation
GG-48948 Add standalone multi-module pom.xml for gg8-examples - #5
Merged
Merged
Conversation
Add -Dmaven.test.failure.ignore=true so the reactor completes, then echo every failing surefire .txt report into the live log (collapsed into ::group::) and upload the whole surefire-reports tree as an artifact. The GHA log endpoint truncates at ~8MB and the Ignite test framework's JUL output drowns out the per-suite summaries — this gives us the actual stack traces.
When the main try-block throws (e.g. csvread cannot resolve its dataset), the finally block also throws because the second table was never created. The finally-exception then masks the real cause. Switching the cleanup DROP statements to IF EXISTS lets the original exception propagate to the test harness — and is correct cleanup regardless.
CE disables a handful of H2 built-in functions (CSVREAD, FILE_READ, …) by default for security (DistributedSqlConfiguration.DFLT_DISABLED_FUNCS). The SQL examples bulk-load datasets via H2's csvread, which then dies with 'Function CSVREAD not found' under the suite. Restore the original H2 function table once the shared Ignite is up — mirrors the reflection-based pattern in CacheSpringStoreSessionListenerSelfTest. The MovieLens SQL example should clear up as a knock-on effect: with the Titanik tests no longer leaking the shared 'dummy_cache' (their finally now actually destroys it), MovieLens's getOrCreateCache will create a fresh cache that registers the predictRecommendation UDF.
head -3 missed the 'Tests run:' line (it lives at line 4 after the header) so the previous run reported success despite three ML errors. Grep the whole file and only trip on Failures/Errors >= 1 (skipped is normal under the dynamic suite).
Drop -Dmaven.test.failure.ignore=true so Maven exits non-zero on a test failure and the job goes red as expected. Keep -fae so the reactor still gets through both modules and surefire reports land for every one. Failing reports are echoed into the live log on failure; the surefire-reports artifact upload still runs on always.
dant3
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ggsystems.atlassian.net/browse/GG-48948