Use OR operator when add array value to query for various actions - #27364
Open
maxiadlovskii wants to merge 12 commits into
Open
maxiadlovskii wants to merge 12 commits into
maxiadlovskii wants to merge 12 commits into
Conversation
linuspahl
requested changes
Sep 24, 2026
linuspahl
left a comment
Contributor
There was a problem hiding this comment.
This PR fixes the problem for the "add to query" action, but it looks like other action like "Exclude from results" or "Create Event Definition" are still broken
linuspahl
approved these changes
Oct 5, 2026
linuspahl
left a comment
Contributor
There was a problem hiding this comment.
Tested all field value actions successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates value-action query generation for array field values to build field-scoped OR clauses instead of comma-joined values or repeated field predicates.
Array values such as:
associated_assets: id1, id2, id3are now formatted as:
associated_assets:(id1 OR id2 OR id3)Depending on the action context, this is wrapped appropriately:
(associated_assets:(id1 OR id2 OR id3))NOT (associated_assets:(id1 OR id2 OR id3))Changes
Tests
Motivation and Context
fix: #14322
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
/jpd https://github.com/Graylog2/graylog-plugin-enterprise/pull/15852