Skip to content

Use OR operator when add array value to query for various actions - #27364

Open
maxiadlovskii wants to merge 12 commits into
masterfrom
fix/issue-14322
Open

maxiadlovskii wants to merge 12 commits into
masterfrom
fix/issue-14322

Conversation

@maxiadlovskii

@maxiadlovskii maxiadlovskii commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

Updates value-action query generation for array field values to build field-scoped OR clauses instead of comma-joined values or repeated field predicates.
Array values such as:
associated_assets: id1, id2, id3
are now formatted as:
associated_assets:(id1 OR id2 OR id3)
Depending on the action context, this is wrapped appropriately:
(associated_assets:(id1 OR id2 OR id3))
NOT (associated_assets:(id1 OR id2 OR id3))
Changes

  • Added shared value-action query helpers for OR-formatting array values.
  • Updated Add to query to use the shared field-scoped OR clause.
  • Updated Exclude from query to negate the grouped field-scoped OR clause.
  • Updated Insert into dashboard/search to pass array values as (id1 OR id2 OR id3) parameter values.
  • Updated Create event definition query generation to use the same field-scoped OR formatting for array values.
  • Preserved existing scalar behavior and aggregation value-path behavior.

Tests

  • Added/updated unit coverage for:Add-to-query array formatting
  • Exclude-from-query array formatting
  • Shared value-action query helper formatting
  • Insert-into-dashboard/search parameter formatting
  • Create-event-definition array query generation

Motivation and Context

fix: #14322

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@linuspahl linuspahl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes the problem for the "add to query" action, but it looks like other action like "Exclude from results" or "Create Event Definition" are still broken

@maxiadlovskii maxiadlovskii changed the title Use OR operator when add array value to query Use OR operator when add array value to query for various actions Sep 30, 2026

@linuspahl linuspahl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all field value actions successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants