fix: crash dans listener-loader quand aucun argument d'événement n'a .guild#153
Open
RedsTom wants to merge 1 commit into
Open
fix: crash dans listener-loader quand aucun argument d'événement n'a .guild#153RedsTom wants to merge 1 commit into
RedsTom wants to merge 1 commit into
Conversation
- Add optional chaining to prevent crash in guildId resolution - Add fallback for message.guild/message.guildId (handles messageReactionAdd/Remove events where the reaction object doesn't have a direct .guild property) - Remove incorrect arg.roles check (GuildMember.id is user ID, not guild ID) - Fix missing .guildId accessor on the guildId fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
TypeError: Cannot read properties of undefined (reading 'guild')sursrc/core/loaders/listener-loader.ts:49quand un événement Discord ne contient aucun argument avec une propriété.guilddirecte.Cela arrivait avec
messageReactionAdd/messageReactionRemove— l'objetMessageReactionn'a pas de.guilddirect (il faut passer parreaction.message.guild).Fix
?.aprèsargs.find(...)sur la ligne.guild?.id→ empêche le crash quand aucun arg n'a.guild.guildIdsur la ligneargs.find((arg) => !!arg?.guildId)→ retourne l'ID au lieu de l'objetmessage.guildetmessage.guildId→ gère les événements commemessageReactionAddoù les infos sont dansarg.messagearg.roles→GuildMember.idest le user ID, pas le guild ID (bug préexistant)