ci: stop a merge from cancelling the proofs - #115
Merged
Conversation
Concurrency was grouped by workflow and ref only, so a scheduled run and a push to main both landed in CI-refs/heads/main and an ordinary merge cancelled whatever was in flight. Observed while dispatching the new jobs: the push from merging #113 at 23:02:19 cancelled the workflow_dispatch run started at 23:00:24. Latent since fuzz was added, and made much worse by #15: kani and miri are the longest jobs in the file, so the window in which a merge can kill them is minutes wide, and the weekly schedule fires regardless of what else is landing. It fails silently, too — a cancelled run is not a red X anyone chases, so the proofs would have quietly stopped running. Adding the event name gives each event type its own lane. Cancelling superseded runs of the same event still happens, which is the part worth keeping: push again to a pull request and the previous run for that branch goes away. Closes #114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114.
Found while dispatching the jobs added in #15. The dispatch was cancelled, and the cause was not the jobs:
Both resolve to
CI-refs/heads/mainundergroup: ${{ github.workflow }}-${{ github.ref }}, so withcancel-in-progress: truethe merge killed the verification run.This has been latent since
fuzzwas added, but #15 made it bite:kaniandmiriare the longest jobs in the file, so the window in which a merge can kill them is minutes wide, and the weekly schedule fires at a fixed time regardless of what else is landing. Worse, it fails silently — a cancelled run is not a red X anyone chases, so the proofs would have stopped running without anyone noticing.Adding
github.event_nameto the group gives each event type its own lane. The behaviour worth keeping is kept: push again to a pull request and the previous run for that branch still goes away.