Skip to content

Prevent nil request panic during resolve - #1423

Draft
monkeyWie with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-docker-download-error
Draft

Prevent nil request panic during resolve#1423
monkeyWie with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-docker-download-error

Conversation

Copilot AI commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Resolve requests with missing req caused a nil-pointer panic in extension URL matching, preventing downloads in Docker deployments.

  • Request validation
    • Return a descriptive error when Downloader.Resolve receives a nil request.
  • Nil-safe extension matching
    • Make Script.match reject nil requests before accessing URL or labels.
  • Regression coverage
    • Add tests for nil resolve requests and nil script-match inputs.
if req == nil {
    return nil, errors.New("request cannot be nil")
}

Copilot AI changed the title [WIP] Fix runtime error during docker downloads Prevent nil request panic during resolve Jul 27, 2026
Copilot AI requested a review from monkeyWie July 27, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.9.3 docker版下载不了东西,提示:runtime error: invalid memory address or nil pointer dereference

2 participants