Skip to content

chore: fix incorrect role_bindings var description - #39

Open
bhegazy wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
bhegazy:main
Open

chore: fix incorrect role_bindings var description#39
bhegazy wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
bhegazy:main

Conversation

@bhegazy

@bhegazy bhegazy commented Nov 28, 2025

Copy link
Copy Markdown

Description

Fix incorrect description for role_bindings variable in variables.tf.

I started to use the module today and found out this copy/paste error

Changes

  • Updated the description of the role_bindings variable to accurately reflect its purpose
  • The previous description was incorrectly copied from max_request_duration_hours variable

@bhegazy
bhegazy requested review from a team, imrannayer and mgaur10 as code owners November 28, 2025 13:11
@google-cla

google-cla Bot commented Nov 28, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@imrannayer imrannayer changed the title docs: fix incorrect role_bindings var description chore: fix incorrect role_bindings var description Nov 29, 2025
@imrannayer imrannayer changed the title chore: fix incorrect role_bindings var description fix: fix incorrect role_bindings var description Nov 29, 2025
@imrannayer imrannayer changed the title fix: fix incorrect role_bindings var description chore: fix incorrect role_bindings var description Nov 29, 2025
@imrannayer

Copy link
Copy Markdown
Member

/gcbrun

@imrannayer

Copy link
Copy Markdown
Member

@bhegazy thanks for the PR. Can you plz submit CLA. Was sent to your bil******zy​@gmail.com address

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions Bot added the Stale label Jan 28, 2026
@github-actions github-actions Bot removed the Stale label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants