feat(spanner): support select for update - #4586
Open
arnabnandy7 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SpannerRepository.findById()uses Spanner's Read API, which cannot express aFOR UPDATEclause. Custom SQL can lock the parent entity, but eagerly loadedinterleaved children are fetched through expression subqueries and are not
locked by an outer
FOR UPDATEclause. Lazy interleaved child queries also didnot inherit locking options.
This can cause excessive transaction aborts when concurrent read-write
transactions read and update the same entity.
Fixes #3984.
Solution
This change adds opt-in
FOR UPDATEsupport for Spring Data Spanner:@Query(forUpdate = true)for derived and custom repository queries.SpannerRepository.findByIdForUpdate(...).SpannerQueryOptions.setForUpdate(true)for programmatic queries.FOR UPDATEto generated parent queries and eager interleaved-childexpression subqueries.
forUpdatewith DML queries.Testing
Added unit coverage for:
findByIdForUpdatevalidation.Targeted test result:
Maven compilation and validation also complete successfully.