add test coverage for all extrnal cli commands/surface [AI] - #1722
Conversation
There was a problem hiding this comment.
Code Review
This pull request expands test coverage for several Ramble CLI commands (such as help, config, clean, workspace, results, and python) and resolves a duplicate pipeline execution bug in the workspace push-to-cache command. The review feedback points out that the deletion of the commands test file removes existing test coverage, which may be accidental. Additionally, it identifies a mismatch in the clean command tests where the '-a' and '--all' flags do not assert against the newly added 'reports' effect.
I am having trouble creating individual review comments. Click here to see my feedback.
lib/ramble/ramble/test/commands.py (1-53)
The file lib/ramble/ramble/test/commands.py has been completely removed in this pull request. This removes all test coverage for the commands CLI command, which seems to contradict the PR's objective of adding test coverage for all external CLI commands/surface. Please verify if this deletion was accidental or if these tests were moved elsewhere.
lib/ramble/ramble/test/cmd/clean.py (58-59)
The expected effects for "-a" and "--all" are hardcoded to ["downloads", "caches", "python_caches"], which excludes "reports". However, all_effects has been updated to include "reports". If the clean -a / clean --all command is intended to clean everything (including reports), these test cases should use all_effects instead of the hardcoded list to avoid test failures or incomplete coverage.
(["-a"], all_effects),
(["--all"], all_effects),
4b3ca28 to
f9f8285
Compare
Ramble Performance Test MetricsResults produced with commit: 5e5e168
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1722 +/- ##
===========================================
+ Coverage 93.63% 93.91% +0.28%
===========================================
Files 367 367
Lines 36307 36468 +161
===========================================
+ Hits 33996 34250 +254
+ Misses 2311 2218 -93 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This PR aims to make sure every top level command an external user could rely on has some test coverage