Fix scaling plot validation - #1718
Merged
Merged
Conversation
Previously the check was performed on a string, such that it gives false positive if the FOM name is a single character.
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the validate_spec method in reports.py to correctly validate the passed chart_spec argument instead of iterating over self.spec. It also updates the corresponding tests and adds a new unit test, test_scaling_plot_invalid_spec, to ensure that scaling plot specifications with fewer than two arguments are properly rejected. There are no review comments, so I have no feedback to provide.
Ramble Performance Test MetricsResults produced with commit: f6f4704
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1718 +/- ##
========================================
Coverage 93.48% 93.48%
========================================
Files 367 367
Lines 35916 35926 +10
========================================
+ Hits 33575 33586 +11
+ Misses 2341 2340 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rfbgo
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the check was performed on a string, such that it gives false positive if the FOM name is a single character.