allow ramble to generate an empty env for injection - #1717
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces auto-construction of undefined software environments when they are required, rather than raising an error immediately. It also adds a check to warn users if an auto-constructed environment contains no packages, along with corresponding unit tests. The feedback suggests replacing the deprecated logger.warn with logger.warning to adhere to modern Python logging standards.
Ramble Performance Test MetricsResults produced with commit: 9bcc6ca
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1717 +/- ##
========================================
Coverage 93.48% 93.48%
========================================
Files 367 367
Lines 35916 35957 +41
========================================
+ Hits 33575 33616 +41
Misses 2341 2341 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
douglasjacobsen
approved these changes
Aug 12, 2026
douglasjacobsen
merged commit Aug 12, 2026
d89d7ec
into
GoogleCloudPlatform:develop
30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the user has to specify an env explicitly, even if it was allowed to be empty.
Ramble now creates a default empty env and allows packages to be injected into it as required. Detecting missing required packages still works the same