Avoid redundant fom prop extraction loop - #1716
Conversation
There was a problem hiding this comment.
Code Review
This pull request corrects the indentation of the block handling older data exports and variable extraction in lib/ramble/ramble/reports.py. The reviewer suggested two improvements: first, checking if fom_type is None rather than just checking for its absence to handle invalid values safely; second, checking if a variable is in _ADDITIONAL_VARS at the beginning of the conditional chain to prevent potential overwrites of additional variables.
Ramble Performance Test MetricsResults produced with commit: e376cc8
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1716 +/- ##
===========================================
+ Coverage 93.48% 93.50% +0.01%
===========================================
Files 367 367
Lines 35916 35948 +32
===========================================
+ Hits 33575 33612 +37
+ Misses 2341 2336 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
947b689
into
GoogleCloudPlatform:develop
No description provided.