Skip to content

Avoid redundant fom prop extraction loop - #1716

Merged
douglasjacobsen merged 2 commits into
GoogleCloudPlatform:developfrom
linsword13:rm-loops
Aug 12, 2026
Merged

Avoid redundant fom prop extraction loop#1716
douglasjacobsen merged 2 commits into
GoogleCloudPlatform:developfrom
linsword13:rm-loops

Conversation

@linsword13

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects the indentation of the block handling older data exports and variable extraction in lib/ramble/ramble/reports.py. The reviewer suggested two improvements: first, checking if fom_type is None rather than just checking for its absence to handle invalid values safely; second, checking if a variable is in _ADDITIONAL_VARS at the beginning of the conditional chain to prevent potential overwrites of additional variables.

Comment thread lib/ramble/ramble/reports.py
Comment thread lib/ramble/ramble/reports.py
@ramble-pr-bot

ramble-pr-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: e376cc8

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.1048 2.1005 (de4ccce) 2.0984
test_large_template_expansion passed 1.6336 1.6327 (de4ccce) 1.6532
test_many_experiments passed 24.7607 24.6595 (de4ccce) 25.4157
test_many_objects_defaults passed 14.1583 14.4773 (de4ccce) 14.4945
test_matrix_filter_perf passed 1.1434 1.1632 (de4ccce) 1.1704

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.50%. Comparing base (de4ccce) to head (e376cc8).

Files with missing lines Patch % Lines
lib/ramble/ramble/test/reports.py 97.05% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1716      +/-   ##
===========================================
+ Coverage    93.48%   93.50%   +0.01%     
===========================================
  Files          367      367              
  Lines        35916    35948      +32     
===========================================
+ Hits         33575    33612      +37     
+ Misses        2341     2336       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@douglasjacobsen
douglasjacobsen merged commit 947b689 into GoogleCloudPlatform:develop Aug 12, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants