introduce standard containerized variant - #1715
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a reserved containerized variant to Ramble, defaulting to False. It allows applications to conditionally define container-related variables (such as mounts) using with when("+containerized"):. Workflow managers like gke-mpi and slurm-pyxis are marked as containerized (is_containerized = True), which automatically propagates the containerized=True variant to their associated applications unless overridden. Unit tests are also added to verify the reservation, validation, and propagation of this variant. I have no feedback to provide as there are no review comments.
Ramble Performance Test MetricsResults produced with commit: d408072
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1715 +/- ##
===========================================
+ Coverage 93.48% 93.49% +0.01%
===========================================
Files 367 367
Lines 35916 35977 +61
===========================================
+ Hits 33575 33638 +63
+ Misses 2341 2339 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This defines a standard variant +containerized and enables it for the relevant workflow managers. Apps can use this for conditional vars:
eg
The most important thing to review here is the use of
is_containerizedto enable it in the workflow manager classes, as it's kind of like a silent extension to the workflow manager language