Skip to content

Fix the multi-node mpi warning - #1714

Merged
douglasjacobsen merged 1 commit into
GoogleCloudPlatform:developfrom
linsword13:fix-warn
Aug 12, 2026
Merged

Fix the multi-node mpi warning#1714
douglasjacobsen merged 1 commit into
GoogleCloudPlatform:developfrom
linsword13:fix-warn

Conversation

@linsword13

Copy link
Copy Markdown
Member

No description provided.

@ramble-pr-bot

ramble-pr-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: 2d8feb8

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.1171 2.1005 (de4ccce) 2.0984
test_large_template_expansion passed 1.6452 1.6327 (de4ccce) 1.6532
test_many_experiments passed 25.4842 24.6595 (de4ccce) 25.4157
test_many_objects_defaults passed 14.7364 14.4773 (de4ccce) 14.4945
test_matrix_filter_perf passed 1.1528 1.1632 (de4ccce) 1.1704

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a redundant line in base_class.py that incorrectly set n_nodes to 1, and adds a corresponding unit test to verify multi-node MPI command warnings. The reviewer pointed out a potential ValueError when converting n_nodes to an integer if it is not a valid integer string, suggesting a robust try-except block to handle this case.

@linsword13

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in parsing the n_nodes variable where it was previously always evaluated to 1 due to a buggy ternary operator. It also adds a corresponding unit test to verify warnings when running multi-node experiments without an MPI command. The reviewer suggests making the n_nodes parsing more robust by handling float strings, unexpanded placeholders, and potential parsing exceptions gracefully.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.48%. Comparing base (de4ccce) to head (2d8feb8).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1714   +/-   ##
========================================
  Coverage    93.48%   93.48%           
========================================
  Files          367      367           
  Lines        35916    35924    +8     
========================================
+ Hits         33575    33584    +9     
+ Misses        2341     2340    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@douglasjacobsen
douglasjacobsen merged commit dd460f4 into GoogleCloudPlatform:develop Aug 12, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants