Make ramble consider '' as unset and error correctly - #1713
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the MPI variable definition logic in base_class.py to prevent empty or None variables from being incorrectly marked as defined, and corrects the logic for tracking missing MPI variables. The review feedback suggests enhancing the validation of MPI variables by stripping whitespace to robustly handle whitespace-only strings.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Ramble Performance Test MetricsResults produced with commit: 2b7218e
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1713 +/- ##
========================================
Coverage 93.48% 93.48%
========================================
Files 367 367
Lines 35916 35918 +2
========================================
+ Hits 33575 33577 +2
Misses 2341 2341 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
douglasjacobsen
approved these changes
Aug 12, 2026
douglasjacobsen
merged commit Aug 12, 2026
eda7195
into
GoogleCloudPlatform:develop
30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
n_ranks: ''(which is sometimes down byworkspace manage experiments) used to give this misleading error:This PR means that value is no ignored so the appropriate instruction to the user is issued requiring a valid value: