Agents updates - #1711
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several new AI agent skill guides under .agents/skills/ and refactors AGENTS.md to reference these modular skills. Feedback on the changes highlights two main configuration corrections: first, updating the workflow manager declaration in the GCP Cluster Toolkit guide to use the variants: section instead of config:; second, adjusting the Spack integration guide to configure compilers via the explicit compiler: directive within software:packages: rather than inline with % in the spack_spec.
| ramble: | ||
| config: | ||
| workflow_manager: slurm |
There was a problem hiding this comment.
The workflow manager configuration should be declared under the variants: section instead of the config: section, to align with the updated schema where workflow_manager is a variant. Please also update the text on line 101 to refer to variants: workflow_manager: slurm.
| ramble: | |
| config: | |
| workflow_manager: slurm | |
| ramble: | |
| variants: | |
| workflow_manager: slurm |
| openmpi4: | ||
| spack_spec: openmpi@4.1.5 %gcc12 +cuda | ||
| gromacs_pkg: | ||
| spack_spec: gromacs@2023.2 %gcc12 ^openmpi4 |
There was a problem hiding this comment.
According to the compiler association guidelines, compilers should be configured strictly via the compiler: directive within the software:packages: entry, rather than specifying them inline with % in the spack_spec.
| openmpi4: | |
| spack_spec: openmpi@4.1.5 %gcc12 +cuda | |
| gromacs_pkg: | |
| spack_spec: gromacs@2023.2 %gcc12 ^openmpi4 | |
| openmpi4: | |
| spack_spec: openmpi@4.1.5 +cuda | |
| compiler: gcc12 | |
| gromacs_pkg: | |
| spack_spec: gromacs@2023.2 ^openmpi4 | |
| compiler: gcc12 |
1 participant
This update
AGENTS.mdto make it smaller (to reduce context consumption) and move aspects to relevant skills as opposed to being in the agent context. It updates the existingramble-workspace-wizardto address some changes toworkflow_manager(config:vs.variants:) and adds several new skills that can be used in more agentic workflows as needed.