Skip to content

Add unit tests for installrecipe.go part 2#993

Draft
bromivipo wants to merge 2 commits into
GoogleCloudPlatform:masterfrom
bromivipo:installrecipe_part2
Draft

Add unit tests for installrecipe.go part 2#993
bromivipo wants to merge 2 commits into
GoogleCloudPlatform:masterfrom
bromivipo:installrecipe_part2

Conversation

@bromivipo

@bromivipo bromivipo commented May 25, 2026

Copy link
Copy Markdown
Contributor

!!! REVIEW AFTER PART 1 IS MERGED

coverage 64.1-> 89.1 %

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bromivipo
Once this PR has been reviewed and has the lgtm label, please assign savija-tv for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot requested a review from zoltak-g May 25, 2026 11:23
@google-oss-prow

Copy link
Copy Markdown

Hi @bromivipo. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant