Skip to content

Improve unit tests for ospatch/yum_update.go#1012

Open
ganochenkodg wants to merge 7 commits into
GoogleCloudPlatform:masterfrom
ganochenkodg:ospatch-yum-update
Open

Improve unit tests for ospatch/yum_update.go#1012
ganochenkodg wants to merge 7 commits into
GoogleCloudPlatform:masterfrom
ganochenkodg:ospatch-yum-update

Conversation

@ganochenkodg

Copy link
Copy Markdown
Contributor

github.com/GoogleCloudPlatform/osconfig/ospatch/yum_update.go:61: YumUpdateExcludes 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/ospatch/yum_update.go:75: YumDryRun 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/ospatch/yum_update.go:91: RunYumUpdate 73.1% -> 100.0%

@google-oss-prow

Copy link
Copy Markdown

Hi @ganochenkodg. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ganochenkodg ganochenkodg changed the title improve tests for ospatch/yum_update.go Improve unit tests for ospatch/yum_update.go Jun 23, 2026
@ganochenkodg ganochenkodg marked this pull request as ready for review June 23, 2026 20:50
@google-oss-prow google-oss-prow Bot requested a review from zoltak-g June 23, 2026 20:50
Comment thread ospatch/yum_update_test.go Outdated
data := []byte(`
func stringPtr(s string) *string {
return &s
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider to move this function to common utiltests

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ganochenkodg, iliatsuprik
Once this PR has been reviewed and has the lgtm label, please assign burov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow

Copy link
Copy Markdown

@ganochenkodg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
prow/presubmit/gotest f97d543 link true /gotest
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-prow google-oss-prow Bot removed the lgtm label Jun 25, 2026
@google-oss-prow

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants