Improve unit tests for ospatch/yum_update.go#1012
Conversation
|
Hi @ganochenkodg. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ee9e204 to
c31f404
Compare
| data := []byte(` | ||
| func stringPtr(s string) *string { | ||
| return &s | ||
| } |
There was a problem hiding this comment.
consider to move this function to common utiltests
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ganochenkodg, iliatsuprik The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ganochenkodg: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
New changes are detected. LGTM label has been removed. |
github.com/GoogleCloudPlatform/osconfig/ospatch/yum_update.go:61: YumUpdateExcludes 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/ospatch/yum_update.go:75: YumDryRun 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/ospatch/yum_update.go:91: RunYumUpdate 73.1% -> 100.0%