Skip to content

Add unit tests for policies/recipes/steps_linux.go#1004

Open
ganochenkodg wants to merge 7 commits into
GoogleCloudPlatform:masterfrom
ganochenkodg:recipes-steps-linux
Open

Add unit tests for policies/recipes/steps_linux.go#1004
ganochenkodg wants to merge 7 commits into
GoogleCloudPlatform:masterfrom
ganochenkodg:recipes-steps-linux

Conversation

@ganochenkodg

Copy link
Copy Markdown
Contributor

github.com/GoogleCloudPlatform/osconfig/policies/recipes/steps_linux.go:24: mkCharDevice 100.0%
github.com/GoogleCloudPlatform/osconfig/policies/recipes/steps_linux.go:28: mkBlockDevice 100.0%
github.com/GoogleCloudPlatform/osconfig/policies/recipes/steps_linux.go:32: mkFifo 100.0%

@google-oss-prow

Copy link
Copy Markdown

Hi @ganochenkodg. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment thread policies/recipes/steps_linux_test.go Outdated
var mode uint32 = 0666

alreadyExistsPath := utiltest.WriteToTempFileMust(t, "already_exists_fifo", []byte("test"))
t.Cleanup(func() { os.Remove(alreadyExistsPath) })

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is used in each test, so can be extracted into a function

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ganochenkodg, iliatsuprik
Once this PR has been reviewed and has the lgtm label, please assign ekremenetskii for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow Bot removed the lgtm label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants