Add unit tests for policies/recipes/steps_linux.go#1004
Conversation
|
Hi @ganochenkodg. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| var mode uint32 = 0666 | ||
|
|
||
| alreadyExistsPath := utiltest.WriteToTempFileMust(t, "already_exists_fifo", []byte("test")) | ||
| t.Cleanup(func() { os.Remove(alreadyExistsPath) }) |
There was a problem hiding this comment.
that is used in each test, so can be extracted into a function
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ganochenkodg, iliatsuprik The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
github.com/GoogleCloudPlatform/osconfig/policies/recipes/steps_linux.go:24: mkCharDevice 100.0%
github.com/GoogleCloudPlatform/osconfig/policies/recipes/steps_linux.go:28: mkBlockDevice 100.0%
github.com/GoogleCloudPlatform/osconfig/policies/recipes/steps_linux.go:32: mkFifo 100.0%