Skip to content

refactor: Remove maxdiffusion configurations and related code from DAGs #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michelle-yooh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: Remove maxdiffusion configurations and related code from DAGs #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions dags/common/vm_resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,18 +363,6 @@ class DockerImage(enum.Enum):
"gcr.io/tpu-prod-env-multipod/maxtext_jax_stable:"
f"{datetime.datetime.today().strftime('%Y-%m-%d')}"
)
MAXDIFFUSION_TPU_JAX_STABLE_STACK = (
"gcr.io/tpu-prod-env-multipod/maxdiffusion_jax_stable_stack:"
f"{datetime.datetime.today().strftime('%Y-%m-%d')}"
)
MAXDIFFUSION_TPU_STABLE_STACK_NIGHTLY_JAX = (
"gcr.io/tpu-prod-env-multipod/maxdiffusion_jax_stable_stack_nightly:"
f"{datetime.datetime.today().strftime('%Y-%m-%d')}"
)
MAXDIFFUSION_TPU_JAX_STABLE_STACK_CANDIDATE = (
"gcr.io/tpu-prod-env-multipod/maxdiffusion_stable_stack_candidate:"
f"{datetime.datetime.today().strftime('%Y-%m-%d')}"
)
MAXTEXT_GPU_JAX_STABLE = (
"gcr.io/tpu-prod-env-multipod/maxtext_gpu_jax_stable:"
f"{datetime.datetime.today().strftime('%Y-%m-%d')}"
Expand Down
35 changes: 0 additions & 35 deletions dags/sparsity_diffusion_devx/jax_ai_image_candidate_tpu_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,6 @@
"v5-8": [1, 2],
"v6e-256": [1],
}
maxdiffusion_test_configs = {
# accelerator: list of slices to test
"v5-8": [1, 2],
"v6e-256": [1],
}

quarantine_task_group = TaskGroup(
group_id="Quarantine", dag=dag, prefix_group_id=False
Expand All @@ -65,11 +60,6 @@
"gcr.io/tpu-prod-env-multipod/maxtext_stable_stack_candidate:latest",
)]

maxdiffusion_docker_images = [(
SetupMode.STABLE,
"gcr.io/tpu-prod-env-multipod/maxdiffusion_stable_stack_candidate:latest",
)]

for accelerator, slices in maxtext_test_configs.items():
cores = accelerator.rsplit("-", maxsplit=1)[-1]
cluster = config.clusters[accelerator]
Expand All @@ -91,28 +81,3 @@
docker_image=image,
test_owner=test_owner.ROHAN_B,
).run_with_quarantine(quarantine_task_group)

for accelerator, slices in maxdiffusion_test_configs.items():
cores = accelerator.rsplit("-", maxsplit=1)[-1]
cluster = config.clusters[accelerator]
for slice_num in slices:
for mode, image in maxdiffusion_docker_images:
maxdiffusion_jax_stable_stack_test = config.get_gke_config(
num_slices=slice_num,
cluster=cluster,
time_out_in_min=60,
run_model_cmds=(
f"JAX_PLATFORMS=tpu,cpu ENABLE_PJRT_COMPATIBILITY=true TPU_SLICE_BUILDER_DUMP_CHIP_FORCE=true TPU_SLICE_BUILDER_DUMP_ICI=true JAX_FORCE_TPU_INIT=true ENABLE_TPUNETD_CLIENT=true && "
f"pip install . && python src/maxdiffusion/train_sdxl.py src/maxdiffusion/configs/base_xl.yml "
f"pretrained_model_name_or_path=gs://maxdiffusion-github-runner-test-assets/checkpoints/models--stabilityai--stable-diffusion-xl-base-1.0 "
f"revision=refs/pr/95 activations_dtype=bfloat16 weights_dtype=bfloat16 "
f"dataset_name=gs://jfacevedo-maxdiffusion-v5p/pokemon-datasets/pokemon-gpt4-captions_sdxl "
f"resolution=1024 per_device_batch_size=1 "
f"jax_cache_dir=gs://jfacevedo-maxdiffusion/cache_dir/ max_train_steps=20 attention=flash enable_profiler=True "
f"run_name={slice_num}slice-V{cluster.device_version}_{cores}-maxdiffusion-jax-stable-stack-{current_datetime} "
f"output_dir={gcs_bucket.BASE_OUTPUT_DIR}/maxdiffusion-jax-stable-stack-{mode.value}-{accelerator}-{slice_num}/automated/{current_datetime}",
),
test_name=f"maxdiffusion-jax-stable-stack-sdxl-{mode.value}-{accelerator}-{slice_num}x",
docker_image=image,
test_owner=test_owner.ROHAN_B,
).run_with_quarantine(quarantine_task_group)
39 changes: 0 additions & 39 deletions dags/sparsity_diffusion_devx/jax_ai_image_tpu_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
"jax_models_and_performance",
"multipod_team",
"maxtext",
"maxdiffusion",
"tpu",
"jax-stable-stack",
"mlscale_devx",
Expand All @@ -54,11 +53,6 @@
"v5-8": [1, 2],
"v6e-256": [1],
}
maxdiffusion_test_configs = {
# accelerator: list of slices to test
"v5-8": [1, 2],
"v6e-256": [1],
}

quarantine_task_group = TaskGroup(
group_id="Quarantine", dag=dag, prefix_group_id=False
Expand All @@ -68,13 +62,6 @@
(SetupMode.NIGHTLY, DockerImage.MAXTEXT_TPU_JAX_NIGHTLY),
]

maxdiffusion_docker_images = [
(
SetupMode.NIGHTLY,
DockerImage.MAXDIFFUSION_TPU_STABLE_STACK_NIGHTLY_JAX,
),
]

for accelerator, slices in maxtext_test_configs.items():
cores = accelerator.rsplit("-", maxsplit=1)[-1]
cluster = config.clusters[accelerator]
Expand All @@ -96,29 +83,3 @@
docker_image=image.value,
test_owner=test_owner.ROHAN_B,
).run_with_quarantine(quarantine_task_group)

for accelerator, slices in maxdiffusion_test_configs.items():
cores = accelerator.rsplit("-", maxsplit=1)[-1]
cluster = config.clusters[accelerator]
for slice_num in slices:
for mode, image in maxdiffusion_docker_images:
maxdiffusion_jax_stable_stack_test = config.get_gke_config(
num_slices=slice_num,
cluster=cluster,
time_out_in_min=60,
run_model_cmds=(
"export JAX_COORDINATION_SERVICE_HEARTBEAT_TIMEOUT_SECONDS=1200 "
"JAX_ENABLE_COMPILATION_CACHE=false "
f"JAX_PLATFORMS=tpu,cpu ENABLE_PJRT_COMPATIBILITY=true TPU_SLICE_BUILDER_DUMP_CHIP_FORCE=true TPU_SLICE_BUILDER_DUMP_ICI=true JAX_FORCE_TPU_INIT=true ENABLE_TPUNETD_CLIENT=true && "
f"pip install . && python src/maxdiffusion/train_sdxl.py src/maxdiffusion/configs/base_xl.yml "
f"pretrained_model_name_or_path=gs://maxdiffusion-github-runner-test-assets/checkpoints/models--stabilityai--stable-diffusion-xl-base-1.0 "
f"revision=refs/pr/95 activations_dtype=bfloat16 weights_dtype=bfloat16 "
f"dataset_name=gs://jfacevedo-maxdiffusion-v5p/pokemon-datasets/pokemon-gpt4-captions_sdxl resolution=1024 per_device_batch_size=1 "
f"jax_cache_dir=gs://jfacevedo-maxdiffusion/cache_dir/ max_train_steps=20 attention=flash enable_profiler=True "
f"run_name={slice_num}slice-V{cluster.device_version}_{cores}-maxdiffusion-jax-stable-stack-{current_datetime} "
f"output_dir={gcs_bucket.BASE_OUTPUT_DIR}/maxdiffusion-jax-stable-stack-{mode.value}-{accelerator}-{slice_num}/automated/{current_datetime}",
),
test_name=f"maxdiffusion-jax-ai-image-{mode.value}",
docker_image=image.value,
test_owner=test_owner.ROHAN_B,
).run_with_quarantine(quarantine_task_group)
149 changes: 0 additions & 149 deletions dags/sparsity_diffusion_devx/maxdiffusion_tpu_e2e.py
View file
Open in desktop

This file was deleted.

Loading