Skip to content

Convert google_cloud_security_compliance_framework cloud_control_details to TypeSet#17770

Draft
Capstan wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
Capstan:capstan/cloudsecuritycompliance-framework-set
Draft

Convert google_cloud_security_compliance_framework cloud_control_details to TypeSet#17770
Capstan wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
Capstan:capstan/cloudsecuritycompliance-framework-set

Conversation

@Capstan
Copy link
Copy Markdown
Member

@Capstan Capstan commented May 30, 2026

Description

This change converts the cloud_control_details parameter inside the google_cloud_security_compliance_framework resource from a List to an unordered_list (Set).

Rationale

Currently, cloud_control_details is modeled as a standard List. During evaluation, the backend REST API returns these control details in an arbitrary, unsorted order. Because the provider compares these as an ordered list, it frequently detects plan-drift differences and attempts to swap the list elements in-place during every plan/apply cycle, causing noisy plan output.

Converting the schema definition to unordered_list (Set) ensures that element ordering is ignored during plan comparison, completely eliminating this plan-drift noise.

Breaking Change Note

As this change alters the resource's underlying state schema representation, it is a breaking change and is proposed strictly to be merged in the upcoming major provider release (TPG v6.0.0).

cloudsecuritycompliance: converted `cloud_control_details` inside `google_cloud_security_compliance_framework` from a List to a Set to prevent continuous plan-drift index swaps.

@Capstan Capstan force-pushed the capstan/cloudsecuritycompliance-framework-set branch from cb4f3c3 to 6fb4d06 Compare May 30, 2026 21:56
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 30, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cb4f3c3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 54 insertions(+)
google-beta provider View Diff 2 files changed, 54 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
7 6 0 1
Affected Service Packages
  • cloudsecuritycompliance

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCloudSecurityComplianceFramework_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccCloudSecurityComplianceFramework_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Capstan VCR tests complete for cb4f3c3!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 30, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6fb4d06:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 54 insertions(+)
google-beta provider View Diff 2 files changed, 54 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
7 6 0 1
Affected Service Packages
  • cloudsecuritycompliance

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCloudSecurityComplianceFramework_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccCloudSecurityComplianceFramework_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Capstan VCR tests complete for 6fb4d06!

@Capstan Capstan force-pushed the capstan/cloudsecuritycompliance-framework-set branch from 6fb4d06 to afc6e64 Compare May 30, 2026 22:14
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 30, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit afc6e64:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 66 insertions(+), 88 deletions(-)
google-beta provider View Diff 2 files changed, 66 insertions(+), 88 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
7 6 0 1
Affected Service Packages
  • cloudsecuritycompliance

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCloudSecurityComplianceFramework_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccCloudSecurityComplianceFramework_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Capstan VCR tests complete for afc6e64!

…ils to TypeSet

Refactors the cloud_control_details parameter inside the
google_cloud_security_compliance_framework resource schema to be an
unordered_list (TypeSet).

This ignores the arbitrary element ordering returned by the backend REST
API during read evaluations, completely eliminating continuous plan-drift
index-swap warnings.

This is a breaking change targeted at the TPG v6.0.0 release.

Fixes hashicorp/terraform-provider-google#27543
@Capstan Capstan force-pushed the capstan/cloudsecuritycompliance-framework-set branch from afc6e64 to 61e7e7a Compare May 31, 2026 04:08
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 31, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 61e7e7a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 71 insertions(+), 88 deletions(-)
google-beta provider View Diff 2 files changed, 71 insertions(+), 88 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
7 6 0 1
Affected Service Packages
  • cloudsecuritycompliance

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCloudSecurityComplianceFramework_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccCloudSecurityComplianceFramework_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Capstan VCR tests complete for 61e7e7a!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants