Convert google_cloud_security_compliance_framework cloud_control_details to TypeSet#17770
Conversation
cb4f3c3 to
6fb4d06
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cb4f3c3: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6fb4d06: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
6fb4d06 to
afc6e64
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit afc6e64: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
…ils to TypeSet Refactors the cloud_control_details parameter inside the google_cloud_security_compliance_framework resource schema to be an unordered_list (TypeSet). This ignores the arbitrary element ordering returned by the backend REST API during read evaluations, completely eliminating continuous plan-drift index-swap warnings. This is a breaking change targeted at the TPG v6.0.0 release. Fixes hashicorp/terraform-provider-google#27543
afc6e64 to
61e7e7a
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 61e7e7a: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
Description
This change converts the
cloud_control_detailsparameter inside thegoogle_cloud_security_compliance_frameworkresource from a List to anunordered_list(Set).Rationale
Currently,
cloud_control_detailsis modeled as a standard List. During evaluation, the backend REST API returns these control details in an arbitrary, unsorted order. Because the provider compares these as an ordered list, it frequently detects plan-drift differences and attempts to swap the list elements in-place during every plan/apply cycle, causing noisy plan output.Converting the schema definition to
unordered_list(Set) ensures that element ordering is ignored during plan comparison, completely eliminating this plan-drift noise.Breaking Change Note
As this change alters the resource's underlying state schema representation, it is a breaking change and is proposed strictly to be merged in the upcoming major provider release (TPG v6.0.0).