Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

fix kubernetes to,from selection process - #24

Open
raddaoui wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
raddaoui:master
Open

fix kubernetes to,from selection process#24
raddaoui wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
raddaoui:master

Conversation

@raddaoui

Copy link
Copy Markdown
Contributor

remove unneeded intermediate variable from the to_form calculation
which was causing wrong calculation.

remove unneeded intermediate variable from the to_form calculation
which was causing wrong calculation.
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-oss-robot google-oss-robot added the gke-helmsman PSO helmsman project label Mar 18, 2019
@google-oss-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raddaoui
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: erkolson

If they are not already assigned, you can assign the PR to them by writing /assign @erkolson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes gke-helmsman PSO helmsman project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants