chore: adding enable metadata env var for lint testing - #3266
Conversation
Summary of ChangesHello @anshukaira, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a specific environment variable to the linting configuration for Cloud Functions (Gen 2) within the test organization's Terraform setup. The change aims to enable metadata for lint testing purposes, ensuring that the linting process can properly evaluate configurations that rely on this metadata. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request introduces a lint_env configuration for the terraform-google-cloud-functions module in infra/terraform/test-org/org/locals.tf. This change adds the ENABLE_BPMETADATA = "1" environment variable, which is intended to enable metadata generation during lint testing. The modification is consistent with existing patterns for other modules in the repos list and directly addresses the stated purpose of enabling metadata for lint testing. No issues of medium, high, or critical severity were identified in this change.
|
@apeabody I am unable to push this branch, can you help in closure of this PR? |
|
Hi @anshukaira - It needs to also be applied, I'll merge the PR in tandem when that is complete. |
|
applied |
adding enable metadata env var for lint testing
Ref PR : GoogleCloudPlatform/terraform-google-cloud-functions#194