Skip to content

Harden Java PR CI: gate self-hosted (credentialed) jobs behind an approval environment #4462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyy8-L wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Harden Java PR CI: gate self-hosted (credentialed) jobs behind an approval environment #4462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/java-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,14 @@ jobs:
name: Build
timeout-minutes: 60
runs-on: [self-hosted, it]
# Gate untrusted PR code before it runs on the credentialed self-hosted
# runner. Every other [self-hosted, it] job (unit tests -> smoke -> IT)
# transitively `needs: java_build`, so requiring approval here holds the
# whole chain until a maintainer approves the current commit. Configure
# required reviewers on the `fork-ci-approval` environment in repo settings
# to activate this (until then the environment imposes no gate, so merging
# this PR is behavior-neutral).
environment: fork-ci-approval
steps:
- name: Checkout Code
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
Loading