Skip to content

Use hadoop version from parent pom - #4460

Draft
derrickaw wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
derrickaw:20261021_fixDanglingHadoopVersion
Draft

derrickaw wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
derrickaw:20261021_fixDanglingHadoopVersion

Conversation

@derrickaw

Copy link
Copy Markdown
Contributor

Problem: In #4450, dependabot was trying to upgrade hadoop client runtime to 3.5, but that would drift away from the parent one.
Fix: Use parent pom hadoop version.

@derrickaw derrickaw added the improvement Making existing code better label Oct 21, 2026
@derrickaw

Copy link
Copy Markdown
Contributor Author

/gemini review

@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.03%. Comparing base (e54cf31) to head (8f980c7).

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #4460       +/-   ##
=============================================
+ Coverage     33.90%   57.03%   +23.12%     
- Complexity      509     8035     +7526     
=============================================
  Files           215     1156      +941     
  Lines         13251    73756    +60505     
  Branches       1335     8698     +7363     
=============================================
+ Hits           4493    42064    +37571     
- Misses         8388    28891    +20503     
- Partials        370     2801     +2431     
Components Coverage Δ
spanner-templates 84.57% <ø> (∅)
spanner-import-export 72.15% <ø> (∅)
spanner-live-forward-migration 89.02% <ø> (∅)
spanner-live-reverse-replication 80.93% <ø> (∅)
spanner-bulk-migration 89.01% <ø> (∅)
gcs-spanner-dv 88.07% <ø> (∅)
see 966 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the hadoop-client-runtime dependency in it/iceberg/pom.xml to use the ${hadoop.version} property instead of a hardcoded version. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant