Skip to content

add kafka to spanner blueprint, IT etc - #4365

Open
derrickaw wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
derrickaw:20261004_kafkaToSpanner
Open

derrickaw wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
derrickaw:20261004_kafkaToSpanner

Conversation

@derrickaw

@derrickaw derrickaw commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor
  1. add kafka to spanner blueprint, IT etc
  2. update kafka options

@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.00%. Comparing base (5663e39) to head (c5e0358).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4365      +/-   ##
============================================
+ Coverage     33.89%   38.00%   +4.11%     
- Complexity      505      513       +8     
============================================
  Files           215      195      -20     
  Lines         13186    11814    -1372     
  Branches       1320     1197     -123     
============================================
+ Hits           4469     4490      +21     
+ Misses         8350     6956    -1394     
- Partials        367      368       +1     
Components Coverage Δ
spanner-templates ∅ <ø> (∅)
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration ∅ <ø> (∅)
spanner-live-reverse-replication ∅ <ø> (∅)
spanner-bulk-migration ∅ <ø> (∅)
gcs-spanner-dv ∅ <ø> (∅)
see 22 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw added the addition New feature or request label Oct 4, 2026
@derrickaw
derrickaw marked this pull request as ready for review October 4, 2026 14:18
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the Dataflow YAML template library by adding support for streaming data from Apache Kafka to Cloud Spanner. The changes include the necessary template definitions, configuration options, and integration tests. Additionally, the PR performs a cleanup of existing Kafka-based templates to maintain parameter consistency and introduces a new configuration field for read time management.

Highlights

  • New Template Added: Introduced the Kafka to Spanner YAML template, enabling streaming data ingestion from Apache Kafka to Cloud Spanner.
  • Configuration Updates: Refactored Kafka template parameters by removing redundant fields and adding the 'maxReadTimeSeconds' option across Kafka-to-BigQuery and Kafka-to-Iceberg templates.
  • Integration Testing: Added a comprehensive integration test suite for the new Kafka to Spanner template to ensure pipeline reliability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Kafka to Spanner (YAML) template, including its Java interface, options, pipeline definition, documentation, and integration tests. Additionally, it refactors the Kafka options across other YAML templates (BigQuery and Iceberg) by removing several duplicate-related parameters and adding maxReadTimeSeconds. The review feedback identifies critical syntax errors in the newly added KafkaToSpanner.yaml file, specifically pointing out that the filesToCopy and requirements properties are incorrectly formatted and should be defined as standard YAML sequences to prevent parsing and execution failures.

Comment thread yaml/src/main/yaml/KafkaToSpanner.yaml
Comment thread yaml/src/main/yaml/KafkaToSpanner.yaml
@derrickaw
derrickaw force-pushed the 20261004_kafkaToSpanner branch from 033c8f5 to c5e0358 Compare October 6, 2026 19:36
@derrickaw
derrickaw requested a review from damccorm October 7, 2026 18:17
@damccorm

damccorm commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

There's heavy overlap with #4363 (and comments that apply across both) so I'm going to let that one get to completion and then we can follow up with review here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants