[pratickchokhani]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 14.77273% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.90%. Comparing base (82a6277) to head (5478fa5).
⚠️ Report is 61 commits behind head on main.

Files with missing lines	Patch %	Lines
...it/gcp/cloudsql/CloudSqlServerResourceManager.java	0.00%	51 Missing ⚠️
...apache/beam/it/gcp/datastream/SqlServerSource.java	0.00%	23 Missing ⚠️
...m/it/gcp/datastream/DatastreamResourceManager.java	92.30%	0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (14.77%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #4244      +/-   ##
============================================
- Coverage     56.93%   56.90%   -0.03%     
- Complexity     7508     8038     +530     
============================================
  Files          1157     1160       +3     
  Lines         73549    73938     +389     
  Branches       8662     8710      +48     
============================================
+ Hits          41876    42078     +202     
- Misses        28873    29060     +187     
  Partials       2800     2800              

Components	Coverage Δ
spanner-templates	84.15% <ø> (-0.31%)	⬇️
spanner-import-export	72.16% <ø> (+0.16%)	⬆️
spanner-live-forward-migration	87.77% <ø> (-1.14%)	⬇️
spanner-live-reverse-replication	80.09% <ø> (-0.76%)	⬇️
spanner-bulk-migration	88.34% <ø> (-0.60%)	⬇️
gcs-spanner-dv	86.66% <ø> (-1.36%)	⬇️

Files with missing lines	Coverage Δ
.../org/apache/beam/it/gcp/datastream/JDBCSource.java	19.23% <100.00%> (+3.23%)	⬆️
...m/it/gcp/datastream/DatastreamResourceManager.java	78.93% <92.30%> (+0.82%)	⬆️
...apache/beam/it/gcp/datastream/SqlServerSource.java	0.00% <0.00%> (ø)
...it/gcp/cloudsql/CloudSqlServerResourceManager.java	0.00% <0.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds support for SQL Server migration integration tests for data types. It introduces a new CloudSqlServerResourceManager to manage Microsoft SQL Server instances, adds SqlServerSource to Datastream configurations, updates CI/CD test commands to support SQL Server parameters, and implements comprehensive integration tests for migrating SQL Server data types to both GoogleSQL and PostgreSQL dialect Spanner databases.

Highlights

• SQL Server Integration: Added support for SQL Server as a Datastream source in integration tests, including new resource managers and source configurations.
• New Resource Manager: Introduced CloudSqlServerResourceManager to manage SQL Server database lifecycles and enable CDC (Change Data Capture).
• Integration Testing: Added comprehensive integration tests for SQL Server data types and expressions, including PG-dialect Spanner schema tests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for Microsoft SQL Server to the Datastream-to-Spanner integration tests and resource managers, including a new CloudSqlServerResourceManager, SqlServerSource configuration, and comprehensive data type migration tests (SQLServerDatastreamToSpannerDataTypesIT). Feedback on these changes includes resolving a potential failure when dropping databases due to connection pool pinning, wrapping test teardowns in try-catch blocks to prevent resource leaks, using a thread-safe set for test instances, and providing a default fallback port (1433) for SQL Server connections.