Ignore unsolicited/late HID input reports instead of throwing - #65
Open
Manishrn wants to merge 1 commit into
Open
Ignore unsolicited/late HID input reports instead of throwing#65Manishrn wants to merge 1 commit into
Manishrn wants to merge 1 commit into
Conversation
Wireless SpeechMikes (e.g. Ambient PSM5000) emit unsolicited status/handshake reports on connect, power-cycle and machine lock/unlock, and may deliver command replies after their 5s resolver has already timed out. These reach the final else-branch of onInputReport() and previously threw 'Unhandled input report from command N', flooding consumers and window.onerror. Log such reports at debug level and ignore them instead of throwing. The original caller was already rejected on timeout, and the late/stale reply is unusable, so nothing is lost. Adds a regression test covering an unrecognized input report.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wireless SpeechMikes (e.g. Ambient PSM5000) emit unsolicited status/handshake reports on connect, power-cycle and machine lock/unlock, and may deliver command replies after their 5s resolver has already timed out. These reach the final else-branch of onInputReport() and previously threw 'Unhandled input report from command N', flooding consumers and window.onerror.
Log such reports at debug level and ignore them instead of throwing. The original caller was already rejected on timeout, and the late/stale reply is unusable, so nothing is lost.
Adds a regression test covering an unrecognized input report.