Bump targetSdkVersion to 36 - #1050
Conversation
|
I was working on the same bump when this PR appeared: I had claimed it in #1047 earlier today, and I opened #1051 with my version shortly after this one. Rather than compete, I want to add my test results here, because they verify the exact template change this PR makes. My branch carries the identical targetSdkVersion 36 line, plus a BUILD_TOOLS_VERSION bump. With that branch:
One question for the maintainers: #764 and #862 both paired the target bump with a BUILD_TOOLS_VERSION bump (39d5972). Leaving it at 34.0.0 works, since it only drives the sdkmanager install and the zipalign/apksigner paths, but if the pairing is worth keeping, that companion change is in #1051. |
|
@gstepniewski-google Can we get a review on this? It's rather time-sensitive with the new Google Play requirements. |
|
I am eagerly awaiting this PA |
|
Merged #1051 |
|
Thanks Greg! |
|
Do you confirm that this change is really included in the last release? When I use the latest Docker container ( the result is still I know I can update it manually, but I was expecting bubblewrap to do it for me. Thanks! |
|
Maybe this is the reason: pwa-builder/PWABuilder#6159 (comment) But that means that whenever the NPM version is released, the docker image needs to be updated too, so it can pull the latest npm package. |
|
@ghnp5 No, these are separate issues. PWABuilder doesn't rely on the Docker container for Bubblewrap. We have our own container. |
Everything tests okay with a simple PWA after upgrading, and passes Google Play's Quick Checks.
35 is going to be unsupported for publishing new versions to Google Play from the end of August according to https://support.google.com/googleplay/android-developer/answer/11926878.